feat: Add support for custom trust policy conditions on iam-github-oidc-role
#547
+54
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBSchami
changed the title
iam-github-oidc-roleiam-github-oidc-role
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Hello @antonbabenko any chance I can get a review on this please? |
antonbabenko
requested changes
Mar 5, 2025
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
antonbabenko
approved these changes
Mar 7, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Mar 7, 2025
## [5.53.0](v5.52.2...v5.53.0) (2025-03-07) ### Features * Add support for custom trust policy conditions on `iam-github-oidc-role` ([#547](#547)) ([3eca351](3eca351))
|
This PR is included in version 5.53.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for custom trust policy conditions to the
iam-github-oidc-rolemodule.Motivation and Context
The GitHub documentation on [security hardening with OpenID connect] (https://docs.github.com/en/actions/security-for-github-actions/security-hardening-your-deployments/about-security-hardening-with-openid-connect) specifies that:
However, this module currently only supports validation of
iss,audandsub. I have a use case where I also want to validateactorandworkflowbut without this change, the module doesn't support that.Breaking Changes
I do not believe this breaks any backwards compatibility. The added variable defaults to an empty array of entries, much like in the
iam-assumable-role-with-oidcmodules and the dynamic configuration will not add anything if no values are provided.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request