fix: Fix IAM policy for External Secrets #545
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Lopez <carloslm@nuclia.com>
bryantbiggs
approved these changes
Jan 9, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Jan 9, 2025
## [5.52.2](v5.52.1...v5.52.2) (2025-01-09) ### Bug Fixes * Fix IAM policy for External Secrets ([#545](#545)) ([883499c](883499c))
|
This PR is included in version 5.52.2 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes updates to the IAM policy document for external secrets in the
modules/iam-role-for-service-accounts-eks/policies.tffile. The changes adjust the actions allowed for the secrets manager.Changes to IAM policy document:
secretsmanager:BatchGetSecretValueaction to the list of allowed actions in one statement.secretsmanager:BatchGetSecretValueaction from another statement to avoid redundancy.Motivation and Context
Two weeks ago, the
0.12.1version was launched for external-secrets. The new version requires a new permission for the actionBatchGetSecretValue.I opened this PR #542 with the suggested changes from the external-secrets repo, and the proposed policy was not working as expected. After reviewing it and reporting it to external-secrets, they finally modified the documentation with a working policy (external-secrets/external-secrets#4275).
The new policy has been tested and works properly with the latest version.
Breaking Changes
No breaking changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request