Support updates in tracing interceptor #1595
Merged
+290
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Aug 16, 2024
interceptor/tracing_interceptor.go
Outdated
| info := workflow.GetInfo(ctx) | ||
| currentUpdateInfo := workflow.GetCurrentUpdateInfo(ctx) | ||
| span, ctx, err := t.root.startSpanFromWorkflowContext(ctx, &TracerStartSpanOptions{ | ||
| Operation: "ExecuteUpdate", |
There was a problem hiding this comment.
Hrmm, I see we didn't call this method HandleUpdate like we have HandleSignal and HandleQuery (and as we may have in other SDKs), but I wonder if we still want the span name to match the other SDKs or match the interceptor method.
There was a problem hiding this comment.
I'm fine matching other SDK's, I don't think the span name needs to match the interceptor name
cretz
approved these changes
Aug 16, 2024
Quinn-With-Two-Ns
force-pushed
the
issue-1588
branch
from
75d60ed to
27d09a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support updates in tracing interceptor
closes #1588