Option to redirect devserver stdout/stderr to a file (#1452)

Author: tebeka

testsuite/devserver.go

@@ -77,6 +77,9 @@ type DevServerOptions struct {
 	LogLevel string
 	// Additional arguments to the dev server.
 	ExtraArgs []string
+	// Where to redirect stdout and stderr, if nil they will be redirected to the current process.
+	Stdout io.Writer
+	Stderr io.Writer
 }
 
 // Temporal CLI based DevServer
@@ -111,6 +114,13 @@ func StartDevServer(ctx context.Context, options DevServerOptions) (*DevServer,
 	args := prepareCommand(&options, host, port, clientOptions.Namespace)
 
 	cmd := newCmd(exePath, args...)
+	if options.Stdout != nil {
+		cmd.Stdout = options.Stdout
+	}
+	if options.Stderr != nil {
+		cmd.Stderr = options.Stderr
+	}
+
 	clientOptions.Logger.Info("Starting DevServer", "ExePath", exePath, "Args", args)
 	if err := cmd.Start(); err != nil {
 		return nil, fmt.Errorf("failed starting: %w", err)

testsuite/process_nonwindows.go

@@ -33,7 +33,8 @@ import (
 // newCmd creates a new command with the given executable path and arguments.
 func newCmd(exePath string, args ...string) *exec.Cmd {
 	cmd := exec.Command(exePath, args...)
-	cmd.Stdout, cmd.Stderr = os.Stdout, os.Stderr
+	cmd.Stdout = os.Stdout
+	cmd.Stderr = os.Stderr
 	return cmd
 }
 

testsuite/process_windows.go

@@ -37,7 +37,9 @@ func newCmd(exePath string, args ...string) *exec.Cmd {
 		// isolate the process and signals sent to it from the current console
 		CreationFlags: syscall.CREATE_NEW_PROCESS_GROUP,
 	}
-	cmd.Stdout, cmd.Stderr = os.Stdout, os.Stderr
+	cmd.Stdout = os.Stdout
+	cmd.Stderr = os.Stderr
+
 	return cmd
 }