Skip to content

Commit c0a1b59

Browse files
authoredOct 25, 2024
Translate gRPC Canceled code to Nexus HandlerErrorTypeInternal (#1680)
1 parent 5505d04 commit c0a1b59

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

Diff for: ‎internal/internal_nexus_task_handler.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -467,11 +467,11 @@ func convertServiceError(err error) error {
467467
errMessage := err.Error()
468468

469469
switch st.Code() {
470-
case codes.AlreadyExists, codes.Canceled, codes.InvalidArgument, codes.FailedPrecondition, codes.OutOfRange:
470+
case codes.AlreadyExists, codes.InvalidArgument, codes.FailedPrecondition, codes.OutOfRange:
471471
return nexus.HandlerErrorf(nexus.HandlerErrorTypeBadRequest, errMessage)
472472
case codes.Aborted, codes.Unavailable:
473473
return nexus.HandlerErrorf(nexus.HandlerErrorTypeUnavailable, errMessage)
474-
case codes.DataLoss, codes.Internal, codes.Unknown, codes.Unauthenticated, codes.PermissionDenied:
474+
case codes.Canceled, codes.DataLoss, codes.Internal, codes.Unknown, codes.Unauthenticated, codes.PermissionDenied:
475475
// Note that codes.Unauthenticated, codes.PermissionDenied have Nexus error types but we convert to internal
476476
// because this is not a client auth error and happens when the handler fails to auth with Temporal and should
477477
// be considered retryable.

0 commit comments

Comments
 (0)