Skip to content

Commit a708f7e

Browse files
authoredJan 10, 2025··
Remove docker flag that disables versioning tests (#1771)
1 parent b8f9b44 commit a708f7e

File tree

4 files changed

+2
-29
lines changed

4 files changed

+2
-29
lines changed
 

Diff for: ‎.github/workflows/ci.yml

-4
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ jobs:
2323
runsOn: macos-13
2424
- os: macos-arm
2525
runsOn: macos-14
26-
2726
runs-on: ${{ matrix.runsOn || matrix.os }}
2827
steps:
2928
- name: Checkout repository
@@ -88,9 +87,6 @@ jobs:
8887
- name: Docker compose - integration tests
8988
if: ${{ matrix.testDockerCompose }}
9089
run: go run . integration-test
91-
env:
92-
# TODO(antlai-temporal): Remove this flag once server 1.26.2 released.
93-
DISABLE_DEPLOYMENT_TESTS: "1"
9490
working-directory: ./internal/cmd/build
9591

9692
cloud-test:

Diff for: ‎.github/workflows/docker/dynamic-config-custom.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ frontend.workerVersioningDataAPIs:
1717
- value: true
1818
frontend.workerVersioningWorkflowAPIs:
1919
- value: true
20+
system.enableDeployments:
21+
- value: true
2022
worker.buildIdScavengerEnabled:
2123
- value: true
2224
worker.removableBuildIdDurationSinceDefault:

Diff for: ‎test/deployment_test.go

-16
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ package test_test
2424

2525
import (
2626
"context"
27-
"os"
2827
"reflect"
2928
"sort"
3029
"strings"
@@ -100,9 +99,6 @@ func (ts *DeploymentTestSuite) waitForReachability(ctx context.Context, deployme
10099
}
101100

102101
func (ts *DeploymentTestSuite) TestPinnedBehaviorThreeWorkers() {
103-
if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
104-
ts.T().Skip("temporal server 1.26.2+ required")
105-
}
106102
ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
107103
defer cancel()
108104

@@ -250,9 +246,6 @@ func (ts *DeploymentTestSuite) TestPinnedBehaviorThreeWorkers() {
250246
}
251247

252248
func (ts *DeploymentTestSuite) TestPinnedOverrideInWorkflowOptions() {
253-
if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
254-
ts.T().Skip("temporal server 1.26.2+ required")
255-
}
256249
ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
257250
defer cancel()
258251

@@ -333,9 +326,6 @@ func (ts *DeploymentTestSuite) TestPinnedOverrideInWorkflowOptions() {
333326
}
334327

335328
func (ts *DeploymentTestSuite) TestUpdateWorkflowExecutionOptions() {
336-
if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
337-
ts.T().Skip("temporal server 1.26.2+ required")
338-
}
339329
ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
340330
defer cancel()
341331

@@ -498,9 +488,6 @@ func (ts *DeploymentTestSuite) TestUpdateWorkflowExecutionOptions() {
498488
}
499489

500490
func (ts *DeploymentTestSuite) TestListDeployments() {
501-
if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
502-
ts.T().Skip("temporal server 1.26.2+ required")
503-
}
504491
ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
505492
defer cancel()
506493

@@ -567,9 +554,6 @@ func (ts *DeploymentTestSuite) TestListDeployments() {
567554
}
568555

569556
func (ts *DeploymentTestSuite) TestDeploymentReachability() {
570-
if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
571-
ts.T().Skip("temporal server 1.26.2+ required")
572-
}
573557
ctx, cancel := context.WithTimeout(context.Background(), 100*time.Second)
574558
defer cancel()
575559

Diff for: ‎test/integration_test.go

-9
Original file line numberDiff line numberDiff line change
@@ -6262,9 +6262,6 @@ func (ts *IntegrationTestSuite) TestScheduleUpdateWorkflowActionMemo() {
62626262
}
62636263

62646264
func (ts *IntegrationTestSuite) TestVersioningBehaviorInRespondWorkflowTaskCompletedRequest() {
6265-
if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
6266-
ts.T().Skip("temporal server 1.26.2+ required")
6267-
}
62686265
versioningBehaviorAll := make([]enumspb.VersioningBehavior, 0)
62696266
ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
62706267
defer cancel()
@@ -6333,9 +6330,6 @@ func (ts *IntegrationTestSuite) TestVersioningBehaviorInRespondWorkflowTaskCompl
63336330
}
63346331

63356332
func (ts *IntegrationTestSuite) TestVersioningBehaviorPerWorkflowType() {
6336-
if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
6337-
ts.T().Skip("temporal server 1.26.2+ required")
6338-
}
63396333
versioningBehaviorAll := make([]enumspb.VersioningBehavior, 0)
63406334
ctx, cancel := context.WithTimeout(context.Background(), ctxTimeout)
63416335
defer cancel()
@@ -6409,9 +6403,6 @@ func (ts *IntegrationTestSuite) TestVersioningBehaviorPerWorkflowType() {
64096403
}
64106404

64116405
func (ts *IntegrationTestSuite) TestNoVersioningBehaviorPanics() {
6412-
if os.Getenv("DISABLE_DEPLOYMENT_TESTS") != "" {
6413-
ts.T().Skip("temporal server 1.26.2+ required")
6414-
}
64156406
seriesName := "deploy-test-" + uuid.New()
64166407

64176408
c, err := client.Dial(client.Options{

0 commit comments

Comments
 (0)
Please sign in to comment.