Fixed problems with S25 barcode #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using your S25 barcode generator I found a problem. The representation of the digit 8 was the same as 0. I fixed it. Now it is recognized correctly. Additionally you were using different bar widths for the start and stop values. I changed this too. One thing I did not change till now is the part where you add an leading 0 if the string is odd. Why do you do so?
|
|
|
Can you please check/use the https://github.com/tecnickcom/tc-lib-barcode instead? |
I checked it and if I'm not wrong S25 is not implemented yet. No code in the formatCode function. |
Closed
nicolaasuni
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using your S25 barcode generator I found a problem. The representation of the digit 8 was the same as 0. I fixed it. Now it is recognized correctly.
Additionally you were using different bar widths for the start and stop values. I changed this too.
One thing I did not change till now is the part where you add an leading 0 if the string is odd. Why do you do so? I can't find anything that S25 has to be even. Maybe you mixed it up with interleaved 2 of 5 bar code where you need the even number because the digits are represented from pairs of bars and whitespaces?