Add support :target filter option on :link selector
#2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add support `:target` filter option on `:link` selector. ## Motivation When wanting to write a test that checks whether the [HTML <a> target attribute](https://www.w3schools.com/tags/att_a_target.asp) has been set to `_blank` or not, it is currently not possible to use matchers like `has_link?`. If passing it as an option raises an invalid option error. ``` Failures: 1) something something test Failure/Error: expect(page).to have_link(target: '_blank') ArgumentError: Invalid option(s) :target, should be one of :above, :below, :left_of, :right_of, :near, :count, :minimum, :maximum, :between, :text, :id, :class, :style, :visible, :obscured, :exact, :exact_text, :normalize_ws, :match, :wait, :filter_set, :focused, :href, :alt, :title, :download ``` Therefore, I would like to support filtering by the target option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support
:targetfilter option on:linkselector.Motivation
When wanting to write a test that checks whether the HTML < a > target attribute has been set to
_blankor not, it is currently not possible to use matchers likehas_link?. If passing it as an option raises an invalid option error.Therefore, we would like to support filtering by the target option. What do you think?