Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take_while should not be random-access #155

Open
tcbrindle opened this issue Jan 22, 2024 · 1 comment
Open

take_while should not be random-access #155

tcbrindle opened this issue Jan 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tcbrindle
Copy link
Owner

This was one of the very first adaptors and I just adapted my ranges implementation without thinking about it too much. But how can we bounds check if we don't know where the end is?

@tcbrindle
Copy link
Owner Author

(An "after pred() has returned false" read isn't going to be UB as the access to the underlying sequence is still going to be bounds checked, but we should still catch this.)

@tcbrindle tcbrindle added the bug Something isn't working label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant