Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Truncate BuildTask.kt before writing #9015

Merged
merged 3 commits into from Feb 28, 2024
Merged

fix(cli): Truncate BuildTask.kt before writing #9015

merged 3 commits into from Feb 28, 2024

Conversation

i-c-b
Copy link
Contributor

@i-c-b i-c-b commented Feb 28, 2024

No description provided.

@i-c-b i-c-b requested a review from a team as a code owner February 28, 2024 04:04
@i-c-b
Copy link
Contributor Author

i-c-b commented Feb 28, 2024

I also noticed the same code for tauri ios init and tauri plugin init --android / tauri plugin android init but neither seems to have BuildTask.kt in their template files. Should I remove their checks for the file?

@amrbashir
Copy link
Member

I think Lucas fixed the android part in #9009 , feel free to just truncate on other platforms.

@lucasfernog
Copy link
Member

lucasfernog commented Feb 28, 2024 •
edited

can't we always truncate?
EDIT: ahh we didn't want to mess with existing files.. let's go with this then

@lucasfernog lucasfernog merged commit b658ded into tauri-apps:dev Feb 28, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@i-c-b @amrbashir @lucasfernog