fix(core): deadlock when creating new window with tracing feature #11213
+35
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the tracing feature is enabled, all eval() calls are synchronous (so we can track how much time they take) so the window creation hooks deadlocks since we're also reacting to a main thread window event at the same time. running the hooks in a separate thread fixes this. closes crabnebula-dev/devtools#352
Package Changes Through f6a80ecThere are 2 changes which include tauri-bundler with patch, tauri with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
reviewed
Oct 4, 2024
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the tracing feature is enabled, all eval() calls are synchronous (so we can track how much time they take) so the window creation hooks deadlocks since we're also reacting to a main thread window event at the same time. running the hooks in a separate thread fixes this.
closes crabnebula-dev/devtools#352