fix: nullable return types of HTMLElement #257
Merged
+23
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is the greatest tool I've ever found. But some types flaw with TypeScript.
Following methods in
HTMLElement
can returnnull
, but do not declare correct return types.getElementById
querySelector
(in README only)nextSibling
nextElementSibling
previousSibling
previousElementSibling
Following methods in
HTMLElement
can returnundefined
, but do not declare correct return types. Actually these should follow the web API and returnnull
, but I did not change them to prevent breaking the backward compability.getAttribute
(in README and jsdocs only)firstChild
lastChild