- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(useResizeColumns): optimize dispatch count #3231
perf(useResizeColumns): optimize dispatch count #3231
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @tannerlinsley on Vercel. @tannerlinsley first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-table/6RtEDWoTet8o4gw8HadbUZLAk9Qy |
👍 I tested this locally and was able to log notably fewer dispatch calls and no noticeable side effects |
hey! @tannerlinsley please lmk if there's anything else you want to see to help review this pr |
Based on PR: TanStack#3231
Based on PR: TanStack#3231
This works perfectly. Hope this gets merged soon. |
What's the plan to get this merged and released? Anything we can do to help with it? |
Pulls in patch to optimize the number of calls to dispatch(), from TanStack/table#3231.
Guys, why still not merged? |
polite bump! |
This pull request is being marked as stale (no activity in the last 14 days) |
This pull request has been detected as stale (no activity in the last 14 days) and automatically closed. It's very likely that your pull request has remained here this long because it introduces breaking changes to the v7 API. React Table v8 is currently in alpha (soon beta!) and already contains bug fixes, performance improvements and architectural changes that likely address the issue this pull request is meant to solve.
|
😢 |
I'll reopen this if anyone wants to do the research on how supported RAF is without a polyfill |
IE10+ |
Good enough for me. |
Before I can merge this, I need to set up my semantic release to handle other branches/ previous versions. |
Pulls in patch to optimize the number of calls to dispatch(), from TanStack/table#3231.
👋 hey internet, here's an optimization that significantly improves column resize performance
dispatch()
when i interactively drag the handle back and forth in the "column-resizing" demo