Allow plugins from a parent document to be used in an iframe #12208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
# Conflicts: # CHANGELOG.md
|
Thanks — this was a much simpler fix for that problem than I expected. It'll be available in out insiders build in probably about 15 minutes or so: |
thecrypticace
added a commit
that referenced
this pull request
Oct 23, 2023
* Fix cross iframe isPlainObject check * Update changelog --------- Co-authored-by: Jordan Pittman <jordan@cryptica.me>
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11899, to make
isPlainObjectutil could work across iframe.Another example that uses the
cdn.tailwindcss.comin iframe, we have to useObject.create(null)as workaround.