kube,tailcfg: store parsed recorder tags in a separate field #12429
+24
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maisem
reviewed
Jun 11, 2024
kube/grants.go
Outdated
| // This list must not contain more than one tag. The field | ||
| // name matches the `Recorder` field with equal semantics for Tailscale | ||
| // SSH session recorder. This field is set by users in ACL grants and is | ||
| // then parsed by control who resolves the tags and populates RecorderAddrs. |
maisem
reviewed
Jun 11, 2024
kube/grants.go
Outdated
| // matching `dst` of this grant will be recorded and the recording will | ||
| // be sent to the tsrecorder. This field does not exist in the user | ||
| // provided ACL grants - it is populated by control who obtains the | ||
| // addresses by resolving the tags provided via .Recorders field. |
maisem
approved these changes
Jun 11, 2024
Add an additional RecorderAddrs field to tailscale.com/cap/kubernetes capability. RecorderAddrs will only be populated by control with the addresses of any tsrecorder tags set via Recorder. Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <irbe@tailscale.com>
irbekrm
force-pushed
the
irbekrm/kubegrants_split
branch
from
0006621 to
8418e97
Compare
chen8945
pushed a commit
to Ckid-Home/tailscale
that referenced
this pull request
Jul 31, 2024
…le#12429) Add an additional RecorderAddrs field to tailscale.com/cap/kubernetes capability. RecorderAddrs will only be populated by control with the addresses of any tsrecorder tags set via Recorder. Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <irbe@tailscale.com>
Asutorufa
pushed a commit
to Asutorufa/tailscale
that referenced
this pull request
Aug 23, 2024
…le#12429) Add an additional RecorderAddrs field to tailscale.com/cap/kubernetes capability. RecorderAddrs will only be populated by control with the addresses of any tsrecorder tags set via Recorder. Updates tailscale/corp#19821 Signed-off-by: Irbe Krumina <irbe@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an additional
RecorderAddrsfield totailscale.com/cap/kubernetescapability rule to separate the field set by users only, from the field populated by control with the addresses resolved from the tags provided theRecordersfield.Updates tailscale/corp#19821