Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an error on empty doctype #612

Merged
merged 1 commit into from Jun 11, 2023
Merged

Return an error on empty doctype #612

merged 1 commit into from Jun 11, 2023

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented Jun 11, 2023

The parser was crashing with debug assertions enabled but passing with debug assertions disabled

Closes #608

Copy link
Collaborator

@Mingun Mingun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to run cargo fmt and please add a changelog entry.

src/errors.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2023

Codecov Report

Merging #612 (c650153) into master (358cc58) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   64.48%   64.46%   -0.03%     
==========================================
  Files          36       36              
  Lines       16916    16919       +3     
==========================================
- Hits        10909    10906       -3     
- Misses       6007     6013       +6     
Flag Coverage Δ
unittests 64.46% <75.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/errors.rs 11.00% <0.00%> (-0.11%) ⬇️
src/reader/parser.rs 98.70% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

@Tpt Tpt force-pushed the empty-doctype branch 2 times, most recently from 2a37fa2 to c650153 Compare June 11, 2023 13:54
The parser was crashing with debug assertions enabled but passing with debug assertions disabled

Closes tafia#608
@Mingun Mingun merged commit 88a2f27 into tafia:master Jun 11, 2023
6 checks passed
@Mingun Mingun mentioned this pull request Jun 11, 2023
9 tasks
@Tpt Tpt deleted the empty-doctype branch June 25, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug assertion triggered on empty doctype
3 participants