Skip to content

Remove testing wp_parse_url without argument #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

IanDelMar
Copy link
Contributor

$url is required (see function reference).

@szepeviktor
Copy link
Owner

Thank you for spotting this.

Do you agree?

@szepeviktor
Copy link
Owner

szepeviktor commented Nov 17, 2024

Halfdone.

We already have an error.

Function wp_parse_url invoked with 0 parameters, 1-2 required.

Why does this assertion not fail??
Because this is not static analysis but unit testing?

@IanDelMar
Copy link
Contributor Author

IanDelMar commented Nov 17, 2024

Because this is not static analysis but unit testing?

Yes. See the TypeInferenceTestCase. Only the return type is checked.

@szepeviktor szepeviktor merged commit e6a5b0b into szepeviktor:2.x Nov 17, 2024
1 of 2 checks passed
@IanDelMar IanDelMar deleted the wp_parse_url-test branch November 17, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants