fix(serializer): raise TypeError when serializing non-byte like object in binary mode #951
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## next #951 +/- ##
=======================================
Coverage 97.77% 97.78%
=======================================
Files 21 21
Lines 1617 1623 +6
=======================================
+ Hits 1581 1587 +6
Misses 36 36 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: a010e66 | Previous: b7f5a9d | Ratio |
|---|---|---|---|
benchmarks/test_1000x.py::test_1000x_reads |
0.7905086748762699 iter/sec (stddev: 0.05748305327438527) |
0.7985141212181278 iter/sec (stddev: 0.05282275712328596) |
1.01 |
benchmarks/test_1000x.py::test_1000x_writes |
0.7034043441102062 iter/sec (stddev: 0.25133582333366294) |
0.698901352248691 iter/sec (stddev: 0.24551960819132626) |
0.99 |
benchmarks/test_standard.py::test_standard |
0.720447672454809 iter/sec (stddev: 0.06252116930389937) |
0.7294161208407376 iter/sec (stddev: 0.06718845368778603) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
samylaumonier
pushed a commit
to samylaumonier/syrupy
that referenced
this pull request
Mar 9, 2025
# [4.9.0](syrupy-project/syrupy@v4.8.3...v4.9.0) (2025-03-08) ### Bug Fixes * **serializer:** raise TypeError when serializing non-byte like object in binary mode ([syrupy-project#951](syrupy-project#951)) ([2bd0f54](syrupy-project@2bd0f54)) ### Features * add --snapshot-ignore-file-extensions argument to support DVC ([syrupy-project#943](syrupy-project#943)) ([056cc6e](syrupy-project@056cc6e)) * add compose_matchers utility for composing 1 or more matchers ([syrupy-project#952](syrupy-project#952)) ([157dbec](syrupy-project@157dbec)) * add SingleFileAmberSnapshotExtension as a single-file variant of the default amber extension ([syrupy-project#959](syrupy-project#959)) ([a753b7a](syrupy-project@a753b7a)) * include details about created/updated snapshots in detailed report ([syrupy-project#942](syrupy-project#942)) ([25d37ef](syrupy-project@25d37ef))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves docs + error message.
Closes #749