[FrameworkBundle] Do not access the container when the kernel is shut down #58327
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Sep 20, 2024
xabbuh
approved these changes
Sep 20, 2024
OskarStark
approved these changes
Sep 20, 2024
|
cc @HypeMC |
HypeMC
approved these changes
Sep 20, 2024
alexandre-daubois
approved these changes
Sep 20, 2024
derrabus
approved these changes
Sep 20, 2024
yceruto
approved these changes
Sep 20, 2024
|
Thank you @jderusse. |
This was referenced Sep 21, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#58240 play with the container after the kernel was shut down.
This is an issue when the kernel performs a cleanup operation. For instance, the @Nyholm TestBundle deletes cache files as a result, the service is not accessible anymore and triggers errors.
This PR move the call to
container->getbeforekernel::shutdown