[String] Add Spanish inflector with some rules

[dennistobar]

Q	A
Branch?	7.2
Bug fix?	no
New feature?	yes
Deprecations?	no
License	MIT

This PR will create the Spanish Inflector using some easy rules (vowels and some ending letters). There are some problems about the accented words (ie: abdomen/abdómenes), so there is no way to create rules to change it :( some rules are taken from RAE

I used the FrenchInflector as base to create this file and the test suite.

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[carsonbot]

Hey!

Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "7.2 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

[dennistobar]

@OskarStark thanks for comment about return typing 😄

[javiereguiluz]

no and sí have valid plurals according to RAE: noes and síes

See https://www.rae.es/gram%C3%A1tica-b%C3%A1sica/el-n%C3%BAmero/reglas-para-la-formaci%C3%B3n-del-plural/reglas-generales

[dennistobar]

Hi @javiereguiluz I'll follow the guidelines from this page (as my other reference seems too complex). I've noticed that most rules have been implemented, but we're still facing a significant issue with accented words. Unfortunately, there doesn't seem to be a way to make exceptions for them at this time.

[fabpot]

Thank you @dennistobar.

[welcoMattic]

I missed this PR, I think we could also improve Twig filters plural and singular by adding this new Inflector here https://github.com/twigphp/Twig/blob/3.x/extra/string-extra/StringExtension.php#L79

If @dennistobar you are available to do it, I let you the priority. If not, let me know, I can find a moment to make the PR.

[dennistobar]

I missed this PR, I think we could also improve Twig filters plural and singular by adding this new Inflector here https://github.com/twigphp/Twig/blob/3.x/extra/string-extra/StringExtension.php#L79

If @dennistobar you are available to do it, I let you the priority. If not, let me know, I can find a moment to make the PR.

Hi @welcoMattic. I'll try to do it, but is there any guide to follow to do commit?. I'm a newbie in OSS at large scale and I afraid to break something 😅

[welcoMattic]

@dennistobar you can get inspired with my previous PR here : https://github.com/twigphp/Twig/pull/4107/files
If you need some help, you can join the Symfony Devs Slack and ask on #support channel or reach me directly ;) https://symfony.com/slack

[dennistobar]

Hi @welcoMattic I just created the PR... thanks for your guidance 😄