Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] [Command] Fix #54402: Suppress PHP warning when is_readable() tries to access dirs outside of open_basedir restrictions #54403

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

kopfsalat
Copy link

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #54402
License MIT

Suppress PHP warning in CacheClearCommand when is_readable() tries to access dirs outside of open_basedir restrictions

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [FrameworkBundle][Command] Fix #54402: Suppress PHP warning when is_readable() tries to access dirs outside of open_basedir restrictions [FrameworkBundle] [Command] Fix #54402: Suppress PHP warning when is_readable() tries to access dirs outside of open_basedir restrictions Mar 26, 2024
@xabbuh
Copy link
Member

xabbuh commented Mar 26, 2024

For 5.4, right?

@kopfsalat
Copy link
Author

kopfsalat commented Mar 27, 2024

For 5.4, right?

Hi, we're working with 6.4 and I found the bug there, so I worked on the 6.4 branch for this fix. But I just looked into the 5.4 branch and the patch should apply there, too. The line is the same.

@xabbuh xabbuh modified the milestones: 6.4, 5.4 Mar 27, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…eadable() tries to access dirs outside of open_basedir restrictions
@xabbuh
Copy link
Member

xabbuh commented Apr 3, 2024

Thank you @kopfsalat.

@xabbuh xabbuh merged commit e9a7cb9 into symfony:5.4 Apr 3, 2024
9 of 12 checks passed
This was referenced Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants