[Security] Correctly initialize the voter property #54248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fabbot.io check errors seem unrelated to the pull request. |
|
Can you please add a test case? |
|
Sure thing, test added. I reverted the change so you can see the test failing and then re-added the fix 🙃 |
aschempp
force-pushed
the
fix/empty-voters
branch
from
994db4c
to
51c24e9
Compare
|
@aschempp it looks like you forgot to re-add the fix |
|
Sorry about that, I pushed now. I had to wait for the queue to fail and went off to something else 🙈 |
xabbuh
approved these changes
Mar 14, 2024
nicolas-grekas
force-pushed
the
fix/empty-voters
branch
from
376489b
to
b184401
Compare
|
Thank you @aschempp. |
This was referenced Apr 2, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the basic issue that causes #54225. If
getVoters()returns an empty array, the$this->data['voters']property is never initialized, and therefore returns an invalid value.@fritzmg or I will follow up if necessary with a fix about decorated access decision managers that cannot "provide" their voters for tracing.