[Validator] Allow BICs’ first four characters to be digits #54219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Mar 11, 2024
xabbuh
approved these changes
Mar 11, 2024
mvhirsch
approved these changes
Mar 11, 2024
|
Thank you @MatTheCat. |
This was referenced Apr 2, 2024
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Apr 10, 2024
…MatTheCat) This PR was merged into the 7.1 branch. Discussion ---------- [Validator] Deprecate `Bic::INVALID_BANK_CODE_ERROR` | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | N/A | License | MIT Follow-up of #54219: now that `Bic::INVALID_BANK_CODE_ERROR` is no longer referenced, it should be deprecated then removed. Commits ------- 1f73fbd [Validator] Deprecate `Bic::INVALID_BANK_CODE_ERROR`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a lot of sources claim a BIC’s first four characters must be letters, this is not the case since ISO 9362:1994. The confusion may come from SWIFT (ISO 9362’s registration authority) saying that
Source (clicking this link will trigger a download)
However, the next paragraph says
As @luxemate stumbled on such a valid BIC (see linked issue), this PR removes the
Bic::INVALID_BANK_CODE_ERRORcheck. This constant won’t be referenced anymore so it may be deprecated and removed later.