[Mailer] [Brevo] Check that tags is present in payload before calling setTags

[palgalik]

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #54197
License	MIT

tags was removed as a mandatory parameter from Brevo remote event requests in this PR by me. Sadly, I wasn't wary enough, and I didn't added payload check before calling setTags in the PayloadConverter, and it causes TypeErrors.

• With this fix, setTags won't be called anymore if tags are not present in the request
• AbstractMailerEvent defaults tags as empty array, so there is no need to call the setter with empty array parameter

[carsonbot]

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

[GromNaN]

Could you update the PR title to describe the bug fix?

[palgalik]

Could you update the PR title to describe the bug fix?

Sure, done. 👍

[stof]

Please add a test covering the conversion of a payload that has no tags, to prevent regressions.

[palgalik]

Please add a test covering the conversion of a payload that has no tags, to prevent regressions.

Just added a test case where there are no tag in the payload, but I only did it for one event type "request".

What do you think @stof , should I change the existing test cases to add the no tags variation for them also?
I think it's not needed, because the tags checking condition is common for each event type.

[fabpot]

Thank you @palgalik.