[FrameworkBundle] Fix PHP 8.4 deprecation on ReflectionMethod

[alexandre-daubois]

Q	A
Branch?	5.4
Bug fix?	no
New feature?	no
Deprecations?	no
Issues	Part of #54180
License	MIT

This fixes:

16x: Calling ReflectionMethod::__construct() with 1 argument is deprecated, use ReflectionMethod::createFromMethodName() instead
    4x in RouterDebugCommandTest::testDumpAllRoutes from Symfony\Bundle\FrameworkBundle\Tests\Functional
    4x in RouterDebugCommandTest::testSearchMultipleRoutesWithoutInteraction from Symfony\Bundle\FrameworkBundle\Tests\Functional
    4x in RouterDebugCommandTest::testShowAliases from Symfony\Bundle\FrameworkBundle\Tests\Functional
    2x in TextDescriptorTest::testDescribeRouteWithControllerLink from Symfony\Bundle\FrameworkBundle\Tests\Console\Descriptor
    1x in RouterDebugCommandTest::testDumpOneRoute from Symfony\Bundle\FrameworkBundle\Tests\Functional
    ...

[xabbuh]

Suggested change

	$r = \PHP_VERSION_ID < 80300 ? new \ReflectionMethod($controller) : \ReflectionMethod::createFromMethodName($controller);
	$r = \PHP_VERSION_ID < 80400 ? new \ReflectionMethod($controller) : \ReflectionMethod::createFromMethodName($controller);

[alexandre-daubois]

Actually the method is available since 8.3. I'd say let's use it with the lowest version possible?

[derrabus]

I'd say let's use it with the lowest version possible?

I agree. The earlier we can drop conditional code, the better.

[nicolas-grekas]

we don't need any condition if we use explode, isn't it?
aren't there more occurences of this pattern in the codebase? It'd be nice to have only one PR to fix them all.

[derrabus]

we don't need any condition if we use explode, isn't it?

That is correct, but why wouldn't we want to leverage the native method if there is one? I like the current way because it hints at how the code will look like once we drop PHP 8.2 support (8.0 probably?).

[nicolas-grekas]

On my side I have a preference for not planning for more future PRs, preserving git blame, and saving a few possible conflicts :)

[derrabus]

I predict that someone will make that change on 8.0 anyway. 😁

But yeah, explode or condition, both works for me.

[alexandre-daubois]

I agree with the future-proof opinion of your solution. I updated the PR. Also, I could not find other places to update, ReflectionMethod seems always called with two arguments 👍

[derrabus]

Nice catch!

[alexandre-daubois]

Using the limit argument idea comes from ControllerResolver::createController

[nicolas-grekas]

Thank you @alexandre-daubois.