[Serializer] Fix object normalizer when properties has the same name as their accessor

[NeilPeyssard]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #54109
License	MIT

Hello,

This PR fix a bug in object normalization when properties has the same name as their accessor. The current behavior mess up class metadata between properties and methods so the keys in the normalized format does not match the object properties, and metadata are not correctly applied (SerializedName in our exemple).

This bug also affects versions 6.4 and 7+, but I'm not sure if we can merge this PR in these branches without refactoring. Let me know if another PR should be open for version 6.4 and 7.

[NeilPeyssard]

Fabbot doesn't seems happy, but it complains about things which are not in my changes... Should I update it too ?

[nicolas-grekas]

Fabbot doesn't seems happy

You can ignore it

[fabpot]

Thank you @NeilPeyssard.

[michaljusiega]

Hi @fabpot @nicolas-grekas @NeilPeyssard

I think this PR could make BC-Break. In my case in my project (with SF 6.4), I have a lot base-code where a property have the same name as accessor-method.

For example:

<?php

class MyObject {
    public function __construct(
        private readonly bool|null $isVerified,
    ) {
    }

    public function isVerified(): bool|null
    {
        return $this->isVerified;
    }
}

returns before 6.4.6:
['verified' => true];

returns after6.4.6:
['isVerified' => true];

This situation means that if "keys" are sent via the API in the original version, it now has to be fixed, which is a difficult work.

At the moment, only way is to add conflict in composer.json like
"symfony/serializer": ">= 6.4.6"

In my opinion, you have a right - this was bug but this should be fixed in deprecation-way with some warnings. WDYT ?