[HttpClient] Preserve float in JsonMockResponse #54146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibbarth
force-pushed
the
fix/json-mock-response-float
branch
from
2e4751e
to
4d120b8
Compare
|
As this changes default settings and will change output then it's BC break unfortunately IMO. |
I agree. We can't make that change on 6.4. And if we want to implement it in 7.1, the new behavior must be opt-in. |
|
On my side I think we should consider this as a bugfix. The "BC break" aspect shouldn't impact production since the class is for mocks, so the risk is minimal IMHO. Also, this would fix the inconsistency with the "json" option, which does set the flag. |
nicolas-grekas
approved these changes
Mar 4, 2024
fancyweb
approved these changes
Mar 5, 2024
derrabus
approved these changes
Mar 5, 2024
|
Thank you @Jibbarth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am mocking an API Response that can send float in values :
Converting this to a php array and giving it to JsonMockResponse return me an int after, because the missing json_encode flag to keep zero fraction, and leds to issue when I want to deserialize it into a float property.
In my mind it's a bugfix, but if it's considered as a new feature, I can target 7.1.