Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] trigger retry logic when message is a redelivery #54124

Conversation

nikophil
Copy link
Contributor

@nikophil nikophil commented Mar 1, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52903 #53311
License MIT

This PR rollbacks #51756 which was an error

ping @itcodeOstrowski @beermeat

@lermontex
Copy link

@fabpot, @nicolas-grekas

Can you include this fix in the next minor version? This bug prevents you from migrating to Symfony 6.4+ because breaking the message reprocessing logic causes serious errors that cannot be avoided because unprocessed messages are permanently removed from the queue

@nicolas-grekas nicolas-grekas force-pushed the fix/rollback-no-retry-reject-delivered-message branch from 711b2b9 to e397200 Compare March 12, 2024 17:37
@nicolas-grekas
Copy link
Member

Thank you @nikophil.

@nicolas-grekas nicolas-grekas merged commit ad56682 into symfony:6.4 Mar 12, 2024
8 of 10 checks passed
This was referenced Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants