Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] disable turbo in web profiler toolbar to avoid link prefetching #54004

Merged

Conversation

davidgorges
Copy link
Contributor

@davidgorges davidgorges commented Feb 20, 2024

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues symfony/ux#1520
License MIT

This adds data-turbo="false" to the web profiler toolbar html. It has been added already a while ago to the mini-toolbar, and there is already the old data-no-turbolink attribute present.

This fixes an issue with prefetching links in Turbo 8, which causes the Ajax pane to behave weirdly and can even cause unwanted logouts (via the logout link inside the security pane).

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [WebProfilerBundle] disable turbo in web profiler toolbar to avoid li… disable turbo in web profiler toolbar to avoid li… Feb 20, 2024
@davidgorges davidgorges marked this pull request as ready for review February 20, 2024 07:51
@carsonbot carsonbot added this to the 5.4 milestone Feb 20, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas changed the title disable turbo in web profiler toolbar to avoid li… disable turbo in web profiler toolbar to avoid link prefetching Feb 20, 2024
@carsonbot carsonbot changed the title disable turbo in web profiler toolbar to avoid link prefetching [WebProfilerBundle] disable turbo in web profiler toolbar to avoid link prefetching Feb 20, 2024
@nicolas-grekas
Copy link
Member

Thank you @davidgorges.

@nicolas-grekas nicolas-grekas merged commit 1ba6fe3 into symfony:5.4 Feb 20, 2024
7 of 11 checks passed
This was referenced Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants