[FrameworkBundle] Fix config builder with extensions extended in build()
#53989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
force-pushed
the
fix-config-dump
branch
from
798991b
to
5b4943e
Compare
|
@HypeMC this solves the bug for me! Thank you so much for the quick fix! |
src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ConfigBuilderCacheWarmer.php
Outdated
Show resolved
Hide resolved
HypeMC
force-pushed
the
fix-config-dump
branch
from
5b4943e
to
413c495
Compare
|
Sorry I made a comment and then deleted it. The error was on my side. |
chalasr
approved these changes
Feb 20, 2024
src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ConfigBuilderCacheWarmer.php
Outdated
Show resolved
Hide resolved
HypeMC
force-pushed
the
fix-config-dump
branch
3 times, most recently
from
c735fa2
to
0d95a60
Compare
HypeMC
force-pushed
the
fix-config-dump
branch
from
0d95a60
to
7053385
Compare
|
Thank you @HypeMC. |
|
@HypeMC I failed to merge the test case into 6.4, could you please submit it there? |
|
@nicolas-grekas Done, see #54040 |
fabpot
added a commit
that referenced
this pull request
Feb 23, 2024
This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Merge test from 5.4 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #53989 (comment) | License | MIT Commits ------- 31d831d [FrameworkBundle] Merge test from 5.4
This was referenced Feb 27, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is caused by the fact that the Security bundle configuration can be extended in any
Bundle::build()or theKernel::build()methods.