[Process] allow to ignore signals when executing a process #53968
+69
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feat/ignored-signals
branch
2 times, most recently
from
91f2c5e to
96ef3a8
Compare
joelwurtz
force-pushed
the
feat/ignored-signals
branch
from
96ef3a8 to
91bd642
Compare
|
I have applied feedback ready for review |
nicolas-grekas
approved these changes
Mar 18, 2024
|
@joelwurtz Can you have a look at the remaining minor comments? Thank you. |
joelwurtz
force-pushed
the
feat/ignored-signals
branch
from
91bd642 to
c94151d
Compare
|
Done, sorry for the delay, should be good to review |
fabpot
approved these changes
Apr 5, 2024
| @@ -1206,6 +1221,20 @@ public function setOptions(array $options): void | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Define a list of posix signals that will not be propagated to the process. | |||
There was a problem hiding this comment.
Suggested change
| * Define a list of posix signals that will not be propagated to the process. | |
| * Defines a list of posix signals that will not be propagated to the process. |
fabpot
force-pushed
the
feat/ignored-signals
branch
from
c94151d to
7bb6ecf
Compare
|
Thank you @joelwurtz. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Feb 5, 2025
This PR was merged into the 7.2 branch. Discussion ---------- [Process] skip transient test on GitHub Actions | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT same as #59690 for a transient test that was introduced with Symfony 7.1 in #53968 Commits ------- 981236c skip transient test on GitHub Actions
nicolas-grekas
added a commit
that referenced
this pull request
Feb 5, 2025
This PR was merged into the 7.2 branch. Discussion ---------- [Process] skip transient test on GitHub Actions | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT same as #59690 for a transient test that was introduced with Symfony 7.1 in #53968 (#59700 added it to the wrong method 🙈) Commits ------- fc8ee6a skip transient test on GitHub Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow to a process to ignore signals dispatched by PHP
This can be useful when using symfony messenger where the handler would execute a Process and receives a SIGTERM, actually the handler would fail with a
ProcessSignaledExceptioninstead of waiting for the handler to terminate and gracefully shutdown.Please note that ignoring a signal will also disallow to send this signal with the
posix_killfunction