[VarDumper] Fix serialization of stubs with null or uninitialized values #53906
+89
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
bugfix/stub-serialize
branch
from
c764081 to
8bda910
Compare
derrabus
changed the title
derrabus
force-pushed
the
bugfix/stub-serialize
branch
from
8bda910 to
3ffd495
Compare
nicolas-grekas
approved these changes
Feb 12, 2024
|
Thanks @derrabus, just tested this and it solves my issue 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Stub::__sleep()implementation excludes properties from the serialized representation that are set to their defaults, but it cannot tell apart properties with a null value from properties that don't have a default. This is an issue for typed properties that are uninitialized by default.