[FrameworkBundle] Prevent silenced warning by checking if /proc/mount exists #53785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
force-pushed
the
remove-warning-on-mac
branch
from
d3f80bd
to
dced288
Compare
| @@ -204,6 +198,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
|
|
|||
| private function isNfs(string $dir): bool | |||
| { | |||
| if ('Linux' !== \PHP_OS) { | |||
There was a problem hiding this comment.
on 7.1, we have this instead:
if ('/' === \DIRECTORY_SEPARATOR && is_readable('/proc/mounts') && $files = @file('/proc/mounts')) {
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
remove-warning-on-mac
branch
from
dced288
to
349b3e7
Compare
|
Thank you @shyim. |
|
Ohh thanks for pushing into. was traveling. |
This was referenced Feb 27, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cache:clearsometimes throws a warning as it tries to access/proc/mounts. This does not exist on macOS. Therefore I skipped that check completely for non linux systems.Example output from the command line:
