[AssetMapper] Fix exception if assets directory is missing in production

[rynhndrcksn]

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #53669
License	MIT

During deployment some people will compile their assets with Asset Mapper then delete the root assets/ directory. This causes Asset Mapper to throw an exception, and a common work around people mentioned in the issue is to create an empty assets/ directory.

This PR makes it so the exception is only thrown while kernel.debug is equal to true, letting developers know locally that there's an issue, but allowing people to safely do this in their production environments.

[smnandre]

With this PR, if someone runs the following command what would happen, exceptions would not be thrown if some directory is missing ?

APP_ENV=prod sf asset-map:compile

[rynhndrcksn]

@smnandre I've attached 2 screenshots of what happens when the APP_ENV=prod symfony console asset-map:compile command is ran.

If the assets/ directory is in place, then this is the output (as expected):

If the assets/ directory is missing, then this is the output:

So during the deployment/asset compilation process people will still be notified if the assets/ directory is missing :)

[smnandre]

@smnandre I've attached 2 screenshots of what happens when APP_ENV=prod symfony console asset-map:compile command is ran.
So during the deployment/asset compilation process people will still be notified if the assets/ directory is missing :)

Perfect for me, thank you very much 👍

[nicolas-grekas]

Thank you @rynhndrcksn.

[nicolas-grekas]

I set this to true by default in aa469d9

[rynhndrcksn]

When I did that locally while my project was set to prod mode, it causes Symfony to crash and return a 500 error.

Is it possible that param('kernel.debug'), (link to line) isn't passing in false when the site is in prod mode, making AssetMapperRepository.php default to true, making it so the $this->debug checks succeed while the site is in prod mode?

[stof]

you can still use the prod environment in debug mode if you want locally. The prod environment defaults to non-debug mode, but the APP_DEBUG env variable still wins over this default.