[Translation] Fix constant domain resolution in PhpAstExtractor #53624
+39
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
fix/constant-domain
branch
from
44cb849 to
a357f58
Compare
welcoMattic
reviewed
Jan 24, 2024
src/Symfony/Component/Translation/Extractor/PhpAstExtractor.php
Outdated
Show resolved
Hide resolved
stof
reviewed
Jan 24, 2024
src/Symfony/Component/Translation/Extractor/PhpAstExtractor.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
fix/constant-domain
branch
from
8498b80 to
c43f6c0
Compare
|
Thank you @VincentLanglet. |
fabpot
added a commit
that referenced
this pull request
Feb 21, 2024
…s (rvanvelzen) This PR was merged into the 6.4 branch. Discussion ---------- [Translation] Fix extracting qualified `t()` function calls | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53835 | License | MIT `t()` calls are generally qualified. The visitor used to look at the full name for the function call, but since #53624 this is replaced by the qualified name. This PR adjusts the comparison to only look at the last part of the qualified name. Commits ------- eb5ac71 [Translation] Fix extracting qualified t() function calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #53357
Closes #53356