Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge]  run composer update for compatibility with PHPUnit versions shipping composer.lock #52846

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 1, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52844
License MIT

@carsonbot carsonbot added this to the 5.4 milestone Dec 1, 2023
@carsonbot carsonbot changed the title [PhpUnitBridge] run composer update for compatibility with PHPUnit versions shipping composer.lock [PhpUnitBridge]  run composer update for compatibility with PHPUnit versions shipping composer.lock Dec 1, 2023
Copy link
Contributor

@joelwurtz joelwurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that it correctly resolve also our issue that we have since today where simple-phpunit was not linking the symfony phpunit bridge, resulting in a PHP Fatal error: Trait "Symfony\Bridge\PhpUnit\Legacy\PolyfillAssertTrait" not found in /app/server/backend/vendor/bin/.phpunit/phpunit-9.6-0/src/Framework/Assert.php on line 93 error

@xabbuh xabbuh merged commit 735959c into symfony:5.4 Dec 1, 2023
5 of 12 checks passed
@welcoMattic
Copy link
Member

welcoMattic commented Dec 1, 2023

The related issue in PHPUnit is sebastianbergmann/phpunit#5578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants