Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[String] Fix Inflector for 'icon' #52727

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

podhy
Copy link
Contributor

@podhy podhy commented Nov 24, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

Hello,
this PR fixes problem when inflecting icon word into icons. Currently it returns wrong result ica

Please make someone review because I'm not 100% sure if this is the right way how to fix it.

Thank you.

Btw: older versions are also affected and it should be possible to merge it there

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@xabbuh xabbuh modified the milestones: 7.1, 5.4 Nov 24, 2023
@nicolas-grekas
Copy link
Member

Thank you @podhy.

@nicolas-grekas nicolas-grekas merged commit dcbfcb4 into symfony:5.4 Nov 26, 2023
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants