Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console][Process] do not let context classes extend the message classes #52427

Merged
merged 1 commit into from Nov 2, 2023
Merged

[Console][Process] do not let context classes extend the message classes #52427

merged 1 commit into from Nov 2, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 2, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 6.4 milestone Nov 2, 2023
@carsonbot carsonbot changed the title [Process] do not let RunProcessContext extend the RunProcessMessage class [Process]  do not let RunProcessContext extend the RunProcessMessage class Nov 2, 2023
@xabbuh
Copy link
Member Author

xabbuh commented Nov 2, 2023

minor tweak after talking with @kbond about #49813

@xabbuh xabbuh requested a review from chalasr as a code owner November 2, 2023 13:10
@xabbuh xabbuh changed the title [Process]  do not let RunProcessContext extend the RunProcessMessage class [Console][Process] do not let context classes extend the message classes Nov 2, 2023
@xabbuh
Copy link
Member Author

xabbuh commented Nov 2, 2023

also, @kbond is right in that we can make a similar change in RunCommandContext (introduced with #49814)

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 8b13301 into symfony:6.4 Nov 2, 2023
7 of 9 checks passed
@xabbuh xabbuh deleted the pr-49813 branch November 2, 2023 14:48
This was referenced Nov 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@kbond kbond kbond approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Process Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xabbuh @nicolas-grekas @kbond @carsonbot