Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Validator] Fix Constraints\Email::ERROR_NAMES #52406

Merged
merged 1 commit into from Dec 29, 2023

Conversation

mathroc
Copy link
Contributor

@mathroc mathroc commented Nov 1, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

Constraint\Email::ERROR_NAMES contains "STRICT_CHECK_FAILED_ERROR" but there's no constant with that name, it's "INVALID_FORMAT_ERROR"

@carsonbot
Copy link

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.3, 6.4, 7.0.

Cheers!

Carsonbot

@mathroc mathroc changed the base branch from 5.1 to 5.4 November 1, 2023 16:35
@carsonbot carsonbot changed the title fix Constraints\Email::ERROR_NAMES [Validator] fix Constraints\Email::ERROR_NAMES Nov 1, 2023
@OskarStark OskarStark changed the title [Validator] fix Constraints\Email::ERROR_NAMES [Validator] Fix Constraints\Email::ERROR_NAMES Nov 3, 2023
@nicolas-grekas nicolas-grekas added this to the 5.4 milestone Dec 29, 2023
@nicolas-grekas
Copy link
Member

Thank you @mathroc.

@nicolas-grekas nicolas-grekas merged commit a422dfc into symfony:5.4 Dec 29, 2023
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants