Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yaml] Fix deprecated passing null to trim() #52332

Merged
merged 1 commit into from Oct 28, 2023
Merged

[Yaml] Fix deprecated passing null to trim() #52332

merged 1 commit into from Oct 28, 2023

Conversation

javaDeveloperKid
Copy link
Contributor

@javaDeveloperKid javaDeveloperKid commented Oct 27, 2023 •
edited by GromNaN

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Closes #52326
License MIT

@carsonbot carsonbot added this to the 6.3 milestone Oct 27, 2023
@javaDeveloperKid javaDeveloperKid changed the title Fix passing null to trim() [Yaml] Fix passing null to trim() Oct 27, 2023
@javaDeveloperKid javaDeveloperKid changed the title [Yaml] Fix passing null to trim() [Yaml] Fix deprecated passing null to trim() Oct 27, 2023
GromNaN
GromNaN reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR must target the oldest maintained branch where the deprecation exists: 5.4.

You should add a test case in InlineTest::getTestsForParse().

src/Symfony/Component/Yaml/Inline.php Outdated Show resolved Hide resolved
@javaDeveloperKid javaDeveloperKid changed the base branch from 6.3 to 5.4 October 27, 2023 18:31
@xabbuh xabbuh mentioned this pull request Oct 28, 2023
Merged
@carsonbot carsonbot changed the title [Yaml] Fix deprecated passing null to trim() Fix deprecated passing null to trim() Oct 28, 2023
@derrabus derrabus added the Yaml label Oct 28, 2023
@carsonbot carsonbot changed the title Fix deprecated passing null to trim() [Yaml] Fix deprecated passing null to trim() Oct 28, 2023
@xabbuh xabbuh modified the milestones: 6.3, 5.4 Oct 28, 2023
@fabpot
Copy link
Member

fabpot commented Oct 28, 2023

Thank you @javaDeveloperKid.

@fabpot fabpot merged commit b2e372d into symfony:5.4 Oct 28, 2023
8 of 11 checks passed
@fabpot fabpot mentioned this pull request Oct 29, 2023
Merged
@GromNaN GromNaN mentioned this pull request Oct 29, 2023
Merged
xabbuh added a commit that referenced this pull request Oct 29, 2023
@xabbuh
minor #52353 [Yaml] Remove test on Inline::parse(null) (GromNaN)
fc41bf5 
This PR was merged into the 6.4 branch.

Discussion
----------

[Yaml] Remove test on `Inline::parse(null)`

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #52334
| License       | MIT

This test was added by #52332
It becomes wrong with #52334
It was not reverted by eaff34a

Commits
-------

9b10106 Fix wrong yaml parse null test
@fabpot fabpot mentioned this pull request Oct 29, 2023
Merged
This was referenced Oct 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@GromNaN GromNaN GromNaN approved these changes

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr Awaiting requested review from chalasr

Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@javaDeveloperKid @fabpot @GromNaN @derrabus @xabbuh @carsonbot