[HttpFoundation] Do not swallow trailing = in cookie value
#51819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
= in cookie value
|
Or should this be fixed inside HeaderUtils::split() method? |
|
I guess we have similar bugs in other places using |
|
So do you have a proposal on where to fix this? |
|
Well, HeaderUtils should be the place to fix it, but not sure we can fix it with the existing signature (unless we hardcode a special behavior for |
|
The bug is clearly in HeaderUtils, see
|
|
Will check on Monday 👍🏻 |
OskarStark
force-pushed
the
bug/cookie-trailing-equal-sign
branch
from
7cf16b0
to
360e0ad
Compare
|
Review please |
OskarStark
force-pushed
the
bug/cookie-trailing-equal-sign
branch
from
f2d7a47
to
ed51a41
Compare
nicolas-grekas
force-pushed
the
bug/cookie-trailing-equal-sign
branch
2 times, most recently
from
469f98b
to
59d6acf
Compare
nicolas-grekas
approved these changes
Oct 17, 2023
carsonbot
added
Status: Reviewed
and removed
Status: Needs Review
Status: Needs Work
labels
nicolas-grekas
force-pushed
the
bug/cookie-trailing-equal-sign
branch
from
59d6acf
to
77ca01c
Compare
|
Thank you Nicolas!! 👏 |
OskarStark
commented
Oct 17, 2023
| @@ -46,13 +46,15 @@ public static function provideHeaderToSplit(): array | |||
|
|
|||
| [[['foo_cookie', 'foo=1&bar=2&baz=3'], ['expires', 'Tue, 22-Sep-2020 06:27:09 GMT'], ['path', '/']], 'foo_cookie=foo=1&bar=2&baz=3; expires=Tue, 22-Sep-2020 06:27:09 GMT; path=/', ';='], | |||
| [[['foo_cookie', 'foo=='], ['expires', 'Tue, 22-Sep-2020 06:27:09 GMT'], ['path', '/']], 'foo_cookie=foo==; expires=Tue, 22-Sep-2020 06:27:09 GMT; path=/', ';='], | |||
There was a problem hiding this comment.
Suggested change
| [[['foo_cookie', 'foo=='], ['expires', 'Tue, 22-Sep-2020 06:27:09 GMT'], ['path', '/']], 'foo_cookie=foo==; expires=Tue, 22-Sep-2020 06:27:09 GMT; path=/', ';='], | |
| [[['foo_cookie', 'foo==='], ['expires', 'Tue, 22-Sep-2020 06:27:09 GMT'], ['path', '/']], 'foo_cookie=foo===; expires=Tue, 22-Sep-2020 06:27:09 GMT; path=/', ';='], | |
| [[['foo_cookie', 'foo=='], ['expires', 'Tue, 22-Sep-2020 06:27:09 GMT'], ['path', '/']], 'foo_cookie=foo==; expires=Tue, 22-Sep-2020 06:27:09 GMT; path=/', ';='], |
Does this pass as well?
|
Thank you @OskarStark. |
|
Thank you, as you did the reimplementation 👍 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @pschultz as you opened the bug report