[Validator] Un-deprecate passing an annotation reader to AnnotationLoader #51454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 22, 2023
stof
reviewed
Aug 22, 2023
| @@ -212,7 +213,7 @@ public function testLoadGroupSequenceProviderAnnotation() | |||
|
|
|||
| protected function createAnnotationLoader(): AnnotationLoader | |||
| { | |||
| return new AnnotationLoader(); | |||
| return new AttributeLoader(); | |||
There was a problem hiding this comment.
This does not match the return type
There was a problem hiding this comment.
It does, AttributeLoader extends AnnotationLoader. This class (AttributeLoaderTest) has two child classes which override this method. I have to keep the return type wide, otherwise I would break those child classes.
|
Just for the record, I'm working on deprecating the serializer's AnnotationLoader too (and replacing it by an AttributeLoader). 🙂 I'll include this same undeprecation in the coming PR |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51425 deprecated the
AnnotationLoaderclass and its replacement already does not accept an annotation reader anymore. Thus, the deprecation of the constructor parameter is redundant, which is why I propose to take it back.cc @alexandre-daubois