[Console] Aligned multiline text in vertical table #50691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaytaph
force-pushed
the
ticket_50632
branch
3 times, most recently
from
a96e28e
to
a01494a
Compare
|
Seems that fabbot wants to strip away the trailing spaces in the table helper unit-tests, but in these cases they need to be present |
chalasr
approved these changes
Jun 17, 2023
maxbeckers
approved these changes
Jun 17, 2023
chalasr
reviewed
Jun 17, 2023
GromNaN
approved these changes
Jun 17, 2023
stloyd
reviewed
Jun 18, 2023
fabpot
approved these changes
Jun 20, 2023
|
Thank you @jaytaph. |
This was referenced Oct 21, 2023
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Feb 20, 2024
…centLanglet) This PR was merged into the 6.4 branch. Discussion ---------- [Console] Fix display of vertical Table on Windows OS | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Similar to #54001 but the feature was introduced in 6.4 with #50691 Commits ------- e9b0faa Fix vertical table on windows
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Feb 20, 2024
…centLanglet) This PR was merged into the 6.4 branch. Discussion ---------- [Console] Fix display of vertical Table on Windows OS | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Similar to symfony/symfony#54001 but the feature was introduced in 6.4 with symfony/symfony#50691 Commits ------- e9b0faaec5 Fix vertical table on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a vertical table helper in the console, any multi-line (\n) text starts on a new line underneath the header. This fixes so the extra lines are aligned with the first line in the table.