[Cache] Fix RedisTrait::createConnection for cluster

[darkanakin41]

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	No
Deprecations?	No
Tickets	Fix #50509
License	MIT
Doc PR	N/A

When the dsn contains redis_cluster=1 or redis_cluster=true the value was not properly parsed, and the class generated was not the expected RedisCluster.

The reason is that the PHP core function match make a === check.

So, as the dsn is a string, the $params['redis_cluster'] needs to be force to a bool

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[darkanakin41]

I don't know how to fix appveyor :(

[derrabus]

I don't know how to fix appveyor :(

You don't need to. The failure is unrelated to your changes.

[nicolas-grekas]

Thank you @darkanakin41.