Fix Doctrine deprecations #50524
Fix Doctrine deprecations #50524
Conversation
nicolas-grekas
commented
Jun 1, 2023
•
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #50481 |
| License | MIT |
| Doc PR | - |
nicolas-grekas
force-pushed
the
doctrine-deprec
branch
4 times, most recently
from
58e449f
to
cfc74e6
Compare
nicolas-grekas
force-pushed
the
doctrine-deprec
branch
from
cfc74e6
to
6a3a4d7
Compare
| @@ -480,9 +480,11 @@ private function updateSchema(): void | |||
|
|
|||
| $schemaManager = $this->createSchemaManager(); | |||
| $comparator = $this->createComparator($schemaManager); | |||
| $schemaDiff = $this->compareSchemas($comparator, $schemaManager->createSchema(), $this->getSchema()); | |||
| $schemaDiff = $this->compareSchemas($comparator, method_exists($schemaManager, 'introspectSchema') ? $schemaManager->introspectSchema() : $schemaManager->createSchema(), $this->getSchema()); | |||
There was a problem hiding this comment.
@nicolas-grekas actually this change deletes all existing tables in the database 😬
Reverting this code-block fixes the issue.
There was a problem hiding this comment.
Can you please open a new issue if you think that this change is wrong (best with a failing example application)? Comments on closed PRs are likely to get lost.
There was a problem hiding this comment.
By the way, reading the code I fail to see how this change can change the actual behaviour (the new instrospectSchema() method calls createSchema() internally).
There was a problem hiding this comment.
@xabbuh yeah, I also thought so, but when I just reverted this code block (not the entire file) it continued to work as expected. But yes, I'll create a follow-up ticket with a reproducible case. Thanks so far 👍😊
When using `$platform->getAlterSchemaSQL($schemaDiff)` instead of `$schemaDiff->toSaveSql($platform)` causes to call `\Doctrine\DBAL\Schema\SchemaDiff::_toSql($platform, false)` instead of `\Doctrine\DBAL\Schema\SchemaDiff::_toSql($platform, true)`. When $saveMode=false the diff from the schema is getting remove, so actually all other tables ... in the DB are getting deleted
