Add is_valid function to Expression constraint

[DEVizzent]

Q	A
Branch?	6.4 for features
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Fix #11940
License	MIT
Doc PR	TODO

Add is_valid function to the Expression constraint, api the same as ValidatorInterface::validate

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[carsonbot]

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for features".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

[xabbuh]

Is this PR meant to replace #47153?

[DEVizzent]

Is this PR meant to replace #47153?

I'm trying to do it. I saw that ones was stuck for long time. I rebased, but I miss a }, I will work on it this weekend.

[DEVizzent]

Hi @xabbuh ,

Sorry but I don't find the error in the continuous-integration/appveyor/pr. Can you bring me any advice to identify why it's failling?

Thank you so much 😃 When I fix it I think we can replace #47153 for this one.

[xabbuh]

@DEVizzent I don't think the failing job is related to your changes.

[DEVizzent]

@DEVizzent I don't think the failing job is related to your changes.

This time most of jobs have failed, but I only change a CHANGE.log in a commit...
If I did something wrong, let me know and I will try fix it. ;)

[DEVizzent]

Hi @xabbuh
I have updated the branch with 6.4, It's failing the same that in the 6.4 pipeline (https://github.com/symfony/symfony/actions/runs/5613675664). Can I do anything more to get the approval and merge it?

[nicolas-grekas]

I rebased the PR and simplified the implementation a bit.

[nicolas-grekas]

Thank you @DEVizzent.

[nicolas-grekas]

And thank you @verdet23 !

[bendavies]

We tried our 6.3 app on 6.4.x-dev

With an empty cache in a symony app, when is_valid is added, this causes

"Registering functions after calling evaluate(), compile() or parse() is not supported." at ExpressionLanguage.php line 122 {"exception":"[object] (LogicException(code: 0): Registering functions after calling evaluate(), compile() or parse() is not supported. at /vendor/symfony/expression-language/ExpressionLanguage.php:122)

because you are cloning and then adding a function an already cached/parsed ExpressionLangauge object.

[bendavies]

@nicolas-grekas possibly it the clone was your change? i'm finding it hard to tell from the force pushes/rebases.

[nicolas-grekas]

@nicolas-grekas possibly it the clone was your change?

Correct, I missed this. Can you submit a fix?

[bendavies]

I can but I do not understand the desired functionality.
Why do we need a new ExpressionLanguage?
Why are you cloning?
What do you see the fix being?

[nicolas-grekas]

The idea is to not mutate the injected service.
The solution might be to pass a pre-configured service I suppose.

[bendavies]

are you suggesting a new service (same as this one) which ExpressionValidator uses instead?

thanks