[Console] Remove exec and replace it by shell_exec
#50338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't we use |
|
I could try this ... give me a bit of time for that, could become a bigger PR :) |
maxbeckers
force-pushed
the
patch_shell_exec_49646
branch
from
f653612
to
141cb0b
Compare
maxbeckers
changed the title
Terminal::hasSttyAvailable()shell_exec from console component
maxbeckers
commented
May 19, 2023
maxbeckers
force-pushed
the
patch_shell_exec_49646
branch
from
141cb0b
to
ae6c457
Compare
chalasr
reviewed
May 19, 2023
maxbeckers
force-pushed
the
patch_shell_exec_49646
branch
from
ae6c457
to
1805f29
Compare
maxbeckers
changed the title
shell_exec from console componentexec and replace it by shell_exec
maxbeckers
force-pushed
the
patch_shell_exec_49646
branch
from
1805f29
to
e178853
Compare
maxbeckers
force-pushed
the
patch_shell_exec_49646
branch
from
e178853
to
c32e4e1
Compare
maxbeckers
force-pushed
the
patch_shell_exec_49646
branch
from
c32e4e1
to
6166fc4
Compare
maxbeckers
force-pushed
the
patch_shell_exec_49646
branch
from
18352ae
to
bf1ae1a
Compare
nicolas-grekas
approved these changes
May 19, 2023
|
Thank you @maxbeckers. |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could happen an error like
Error: Call to undefined function Symfony\Component\Console\shell_exec() in /{path_to_project}/vendor/symfony/console/Application.php:989whenexecis available butshell_execnot. There is very often used the checkTerminal::hasSttyAvailable()in the symfony codebase and thenshell_execused.More Details see in the issue #49646.