Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfiler] dark mode on tab navigation list #50210

Closed
94noni opened this issue May 2, 2023 · 4 comments · Fixed by #50249
Closed

[WebProfiler] dark mode on tab navigation list #50210

94noni opened this issue May 2, 2023 · 4 comments · Fixed by #50249

Comments

@94noni
Copy link
Contributor

94noni commented May 2, 2023

Symfony version(s) affected

6.2+

Description

I just wanted to report a small UI issue on web profiler in dark mode: 2 tab list have not the same text color in dark mode

rr

l

How to reproduce

web profiler with dark mode enabled

Possible Solution

I do not know if it is specific symfony profiler bundle asset or it is the Tabler asset itself
I can investigate further when in vacation but if someone find the clue faster, I opened this issue

Additional Context

No response

@OskarStark
Copy link
Contributor

Friendly ping @javiereguiluz

@MatTheCat
Copy link
Contributor

I’m not able to reproduce on Symfony 6.2.10:

Could you provide a reproducer? I see your screenshots are missing a heading too.

@94noni
Copy link
Contributor Author

94noni commented May 6, 2023

It is a profiler of a sf6.2 project i tested upgrading to sf6.3 with browser clear cache etc
When rollbacking to sf6.2 still same

put the issue in standby until i retry from scratch perhaps

@MatTheCat
Copy link
Contributor

Okay this stems from #48762 (so, 6.3) because browsers’ buttons color takes precedence over the inherited one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants