[PropertyAccess] Allow escaping in PropertyPath #49331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
changed the title
chalasr
approved these changes
Feb 14, 2023
carsonbot
changed the title
carsonbot
changed the title
yceruto
approved these changes
Feb 14, 2023
|
Thank you @alanpoulain. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if it can be considered a feature or a fix.
Currently there is no way to escape
.and[when usingPropertyPath.It can cause issue when we want to access a "property" containing a dot (for instance a key in an array).
I tried to modify the regexp as little as possible and to handle (really) edge cases such as double escaping.
Initially I had the issue in some Behat tests where I needed to evaluate some paths in a big JSON file (OpenAPI documentation).
Some keys contain dots and I cannot test the JSON node when it's the case.