[Yaml] Feature #48920 Allow milliseconds and microseconds in dates #49164
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot
changed the title
|
@GromNaN The documentation mentions I need to squash before the pull request will be accepted do I still need to do this? |
|
@dustinwilson if you allow maintainers to edit your PR (which is the case for this PR), our tooling can manage the squashing automatically. |
|
@stof Okay. Thanks! |
CHANGELOG-6.2.md
Outdated
| @@ -331,4 +331,3 @@ To get the diff between two versions, go to https://github.com/symfony/symfony/c | |||
| * feature #46430 [Routing] Add `Requirement::POSITIVE_INT` for common ids and pagination (HeahDude) | |||
| * feature #46279 [DependencyInjection] Optimize autowiring logic by telling it about excluded symbols (nicolas-grekas) | |||
| * feature #46452 [DependencyInjection] Add Hydrator::hydrate() and preserve PHP references when using it (nicolas-grekas) | |||
|
|
|||
|
Thank you @dustinwilson. |
This PR was merged into the 6.3 branch. Discussion ---------- [Yaml] Fix parsing sub-second dates on x86 | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Fix #49164 Commits ------- b06b818 [Yaml] Fix parsing sub-second dates on x86
Allows Yaml to parse dates with milliseconds or microseconds and to dump them as well.